On 2024-09-15 at 16:37:34, Junio C Hamano wrote: > Henrik Holst <henrik.holst@xxxxxxxxxxx> writes: > > > If I set LDFLAGS to whatever pkg-config --libs libcurl says on my system (actually: -lcurl -lssl -lcrypto -lzstd -lbrotlidec -lz) then it compiles just fine. If I add LDFLAGS to the configure environment it will accept that test, and then detect, as expected, the pkg-config settings for libcurl. > > > > Should not ./configure FIRST check for a pkg-config environment without assuming that even the most trivial curl programs should compile without any additional dependencies like zstd etc? > > Looking at configure.ac, pkg-config is not used for any package. > Specifically for curl, it seems that "curl-config --libs" is used. > > Presumably the reason behind the current behaviour is combination of > (1) ./configure is an after-thought in the build infrastructure for > this project, (2) pkg-config was not ubiquitous back when autoconf > support was written for this project, and (3) nobody considered > "upgrading" our use of "curl-config" and our manual detection of > dependency detection for other libraries to just use "pkg-config". I'll also note that the traditional expectation is that users are using dynamic libraries, where this would have worked because libcurl would have been linked against all its dependencies, and not static libraries, where all dependencies must be specified explicitly. You almost certainly don't want to statically link libcurl or OpenSSL because you'll have a security issue as soon as one of those packages issues a security update, which will require that you recompile Git to apply the update. With dynamic libraries, security updates are applied as soon as a new process is spawned. -- brian m. carlson (they/them or he/him) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature
