Jeff King <peff@xxxxxxxx> writes: > Yikes, good catch. That's a pretty bad bug. I'm surprised we didn't > cover this in the tests, but it's specific to bare repositories. > >> Bug hunting through the Git.pm code and skimming through the Git SCM >> repo, there's a significant change (commit 20da61f25) that makes the >> recent Git.pm rely on: >> >> git rev-parse --is-bare-repository --git-dir > > Yep, I confirmed via bisection that that commit is the culprit. Yeah, it is surprising that nobody noticed it since Dec 2022. > It does fix all cases, but it leaves some redundant code in place. > Here are two patches. The first does the minimal fix within the code > (what 20da61f25 should have done!) and corrects the problem. The second > switches to --absolute-git-dir and drops the now-redundant code. > > Thank you for a very thorough bug report! Yup, thanks, both. Queued.
