Re: [PATCH v2 3/3] add: pass in repo variable instead of global the_repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 3/3] add: pass in repo variable instead of global the_repository
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Wed, 11 Sep 2024 11:23:37 -0700
Cc: git@xxxxxxxxxxxxxxx, Patrick Steinhardt <ps@xxxxxx>, John Cai <johncai86@xxxxxxxxx>
In-reply-to: <6956d3fe8971475dde87909bb6b9760be6964488.1726001963.git.gitgitgadget@gmail.com> (John Cai via GitGitGadget's message of "Tue, 10 Sep 2024 20:59:20 +0000")
References: <pull.1778.git.git.1725555467.gitgitgadget@gmail.com> <pull.1778.v2.git.git.1726001960.gitgitgadget@gmail.com> <6956d3fe8971475dde87909bb6b9760be6964488.1726001963.git.gitgitgadget@gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13)

"John Cai via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:

> From: John Cai <johncai86@xxxxxxxxx>
>
> With the repository variable available in the builtin function as an
> argument, pass this down into helper functions instead of using the
> global the_repository.

Nicely done.

References:
- [PATCH 0/3] Add repository parameter to builtins
  - From: John Cai via GitGitGadget
- [PATCH v2 0/3] Add repository parameter to builtins
  - From: John Cai via GitGitGadget
- [PATCH v2 3/3] add: pass in repo variable instead of global the_repository
  - From: John Cai via GitGitGadget

Prev by Date: Re: [PATCH v2 2/3] builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
Next by Date: Re: [PATCH 1/4] remote: fix set-branches when no branches are set
Previous by thread: [PATCH v2 3/3] add: pass in repo variable instead of global the_repository
Next by thread: [PATCH v2 2/3] builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]