On Sat, Sep 7, 2024 at 8:15 AM Sean Allred <allred.sean@xxxxxxxxx> wrote: > > Calvin Wan <calvinwan@xxxxxxxxxx> writes: > > Add libgitrs, libgitrs-sys, libgitrs-test, and libgitrs-sys-test targets > > to their respective Makefiles so they can be built and tested without > > having to run cargo build/test. > > I feel like clippy should be run as part of these somehow, but I'm not > sure where. > > > +libgitrs-sys: > > + $(QUIET)(\ > > + cd contrib/libgit-rs/libgit-sys && \ > > + cargo build \ > > + ) > > +.PHONY: libgitrs > > +libgitrs: > > + $(QUIET)(\ > > + cd contrib/libgit-rs && \ > > + cargo build \ > > + ) > > We should definitely be setting `RUSTFLAGS=-Dwarnings` as an analog to > `-Wall` in the C world, no? These crates should build without warnings. > > Very excited to see this work; thank you for putting the time into it > :-) > > -- > Sean Allred Thanks for the suggestions! Will look into both for the next reroll.
