Jeff King <peff@xxxxxxxx> writes: > Now thinking on it more, that view is probably dumb. fstat() is really > cheap, and byte-wise comparisons are really expensive, so if it has even > a tiny chance of helping, it might be worth doing. If we see too many "yikes we need to check for collision" cases, then yes, but I agree that it should be rare to matter. > Though again, I'd hope this will trigger pretty rarely in practice, > because it's probably a sign that we could have skipped work earlier > (i.e., by realizing we were just going to generate an identical file, > and not generated it in the first place). Yes, exactly.