On Tue, Sep 10, 2024 at 12:10:10AM -0400, Eric Sunshine wrote: > Changes since v1: > > * new patch [1/3] -- motivated by Junio's observation[2] about > availability of structured problem information -- takes advantage of > that information directly rather than post-processing "?!...?!" > sequences in the output stream > > * old patch [2/2] (now [3/3]) which drops "?!" decorations when emitting > colored output to a terminal partially justified the change by > claiming that the new "ERR" (or "ERR:") prefix is a good "needle" for > a terminal's search feature, thus the noisy "?!" is no longer needed; > however, I realized that "ERR" (or "ERR:") is, in fact, an awful > needle since the string "err" (or "err:") is quite likely to > legitimately appear in source text, hence I changed the prefix to > "LINT:" (with the colon since Patrick found lack of colon > confusing[3]) > > * rewrote commit messages based upon feedback from Junio[2,4] > > * dropped an unused argument from the call to format_problem() which was > an artifact used briefly during development of v1 Very nice. I think the "LINT:" prefix does a good job of standing out, after spot-checking the output of a few of the tests. I read through the commits themselves and didn't have any suggestions. -Peff
