On Tue, Sep 10, 2024 at 08:09:22AM +0200, Patrick Steinhardt wrote: > > But parse_signature() would never find such a buffer! It only looks for > > signature lines (like "-----BEGIN PGP") at the start of each line, > > without any header keyword. So this code will never find anything except > > the usual in-body signature. > > Okay. So in other words the intent was to parse in-header signatures, > but the code failed to do so correctly and thus this never worked in the > first place? > > In any case, `parse_signature()` is only a glorified wrapper around > `parse_signed_buffer()` in the first place, so in the end they would > both parse the buffer in the same way. > > Nice cleanup, even though it leaves one wondering why the in-header > signatures have only been wired up partially. I, too, was confused. See this exchange with brian: https://lore.kernel.org/git/20240908233636.GA4026999@xxxxxxxxxxxxxxxxxxxxxxx/ -Peff
