Am 07.09.24 um 01:12 schrieb Jorge Luis Martinez Gomez: > Thank you for filling out a Git bug report! > Please answer the following questions to help us understand your issue. > > What did you do before the bug happened? (Steps to reproduce your issue) > > $ mkdir /tmp/git-diff-test; cd /tmp/git-diff-test > $ git init > Initialized empty Git repository in /tmp/git-diff-test/.git/ > $ touch foo > $ git add foo > $ git commit -m "foo" > [main (root-commit) f60d7bc] foo > 1 file changed, 0 insertions(+), 0 deletions(-) > create mode 100644 foo > $ mv foo bar > $ git status -s > D foo > ?? bar > $ git add foo bar > $ git status -s > R foo -> bar > $ git diff --quiet --cached; echo $? > 0 > $ git diff --quiet --cached --no-renames; echo $? > 1 > > What did you expect to happen? (Expected behavior) > > Versions prior to commit d7b97b7185521e3b9364b3abc6553df2480da173 > returned 1 for `git diff --quiet --cached`. Thanks a lot for the reproduction recipe and for bisecting it! > What happened instead? (Actual behavior) > > It returned 0. > > What's different between what you expected and what actually happened? > > The status code. > > Anything else you want to add: > > This bug report originates from a PR I filed with Magit here: > > https://github.com/magit/magit/pull/5221 > > I thought this difference between using `--no-renames` and not made > sense, so I thought the problem lied with Magit. However, like tarsius in > that thread points out, this is a change that happened recently with git > and it's not in the release notes. After finding the commit that > introduces the change, I see the message mentions "The new options are > off by default, keeping the old behavior." It really doesn't seem > intentional, so here's a bug report. Indeed, that's a bug. Affects copies as well. And could be triggered by e.g. --ignore-space-change or --ignore-matching-lines before, like the submodule diff regression reported earlier. René
