On Fri, Sep 6, 2024 at 6:21 PM Calvin Wan <calvinwan@xxxxxxxxxx> wrote:
> From: Josh Steadmon <steadmon@xxxxxxxxxx>
>
> Add git_configset_alloc() and git_configset_clear_and_free() functions
> so that callers can manage config_set structs on the heap. This also
> allows non-C external consumers to treat config_sets as opaque structs.
>
> Co-authored-by: Calvin Wan <calvinwan@xxxxxxxxxx>
> Signed-off-by: Calvin Wan <calvinwan@xxxxxxxxxx>
Almost all these patches suffer from some sort of missing Josh
trailer, so I'll stop mentioning it now.
> diff --git a/config.h b/config.h
> @@ -472,6 +472,11 @@ struct config_set {
> +/**
> + * Alloc a config_set
> + */
> +struct config_set *git_configset_alloc(void);
Should this documentation string mention that git_configset_alloc()
does _not_ initialize the configset? Alternatively, should this
function also initialize it as a convenience (and mention so in the
documentation)?
