On Sun, Sep 1, 2024 at 11:27 PM Ghanshyam Thakkar <shyamthakkar001@xxxxxxxxx> wrote: > > helper/test-oid-array.c along with t0064-oid-array.sh test the > oid-array.h API, which provides storage and processing > efficiency over large lists of object identifiers. > > Migrate them to the unit testing framework for better runtime > performance and efficiency. As we don't initialize a repository > in these tests, the hash algo that functions like oid_array_lookup() > use is not initialized, therefore call repo_set_hash_algo() to > initialize it. And init_hash_algo():lib-oid.c can aid in this > process, so make it public. > > Mentored-by: Christian Couder <chriscool@xxxxxxxxxxxxx> > Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@xxxxxxxxx> > Helped-by: Phillip Wood <phillip.wood123@xxxxxxxxx> > Signed-off-by: Ghanshyam Thakkar <shyamthakkar001@xxxxxxxxx> > --- It would have been nice to briefly summarize here the changes compared to v3. On the other hand they are small enough and this version addresses all the suggestions that were made previously and looks good to me, so I think it is good to go. Thanks!
