Patrick Steinhardt <ps@xxxxxx> writes: > On Thu, Aug 29, 2024 at 04:09:53PM -0400, Jeff King wrote: >> We prove custom malloc/free callbacks for the pcre library to use. Those >> take an extra "data" parameter, but we don't use it. Back when these >> were added in 513f2b0bbd (grep: make PCRE2 aware of custom allocator, >> 2019-10-16), we only had MAYBE_UNUSED. But these days we have UNUSED, >> which we should prefer, as it will let the compiler inform us if the >> code changes to actually use the parameters. >> >> I also moved the annotations to come after the variable name, which is >> how we typically spell it. >> >> Signed-off-by: Jeff King <peff@xxxxxxxx> >> --- >> Where "how we typically spell it" is "me", because I wrote 99% of the >> annotations we have. ;) I'm open to debate, but only if it is >> accompanied by a patch to change all of them to be consistent. > > I don't care about the order, but if we settle on one I think we should > also document this accordingly in our code style guide. Very true. I think Peff's [PATCH 7/6] was sufficient by ending the new instruction with ... like "int foo UNUSED". when it talked about the -Werror=unused-parameter. Thanks.
