On Sat, Nov 10, 2007 at 12:20:22AM +0100, René Scharfe wrote: > > This void cast is pointless, since all pointers types convert implicitly > > to void pointers anyway. At best, it does nothing, and at worst, it > > hides an actual type error if the function signature or the type of > > 'commit' change. > > When commit (of type const struct commit*) is implicitly converted to > void *, gcc complains because the "const" qualifier is silently dropped. Bleh. You're right, of course. I don't like casting away constness, but it is stupid for strbuf_expand to take a "const void *" since it has no idea how it will be used (although I note your caching patch also neatly does away with this, anyway). -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
