On Wed, Aug 21, 2024 at 06:00:50PM +0530, Chandra Pratap wrote: > The reftable library comes with self tests, which are exercised > as part of the usual end-to-end tests and are designed to > observe the end-user visible effects of Git commands. What it > exercises, however, is a better match for the unit-testing > framework, merged at 8bf6fbd0 (Merge branch 'js/doc-unit-tests', > 2023-12-09), which is designed to observe how low level > implementation details, at the level of sequences of individual > function calls, behave. > > Hence, port reftable/block_test.c to the unit testing framework and > improve upon the ported test. The first patch in the series moves > the test to the unit testing framework, and the rest of the patches > improve upon the ported test. > > Mentored-by: Patrick Steinhardt <ps@xxxxxx> > Mentored-by: Christian Couder <chriscool@xxxxxxxxxxxxx> > Signed-off-by: Chandra Pratap <chandrapratap3519@xxxxxxxxx> > > --- > Changes in v3: > - Use block_source_from_strbuf() instead of malloc_block_source() > in log, obj, and index block tests (patches 9, 10, 11). > - Remove a line that causes a memory leak in obj test (patch 10). This addresses all comments I had on the preceding version and plugs the memory leak. So this looks good to me, thanks! Patrick
