Re: [PATCH] tests: git push mirror mode tests V2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andy Whitcroft <apw@xxxxxxxxxxxx> writes:

> +test_expect_success 'push mirror does not create new branches' '
> +
> +	mk_repo_pair &&
> +	(
> +		cd master &&
> +		echo one >foo && git add foo && git commit -m one &&
> +		git push --mirror up
> +	) &&
> +	master_master=$(cd master && git show-ref -s --verify refs/heads/master) &&
> +	mirror_master=$(cd mirror && git show-ref -s --verify refs/heads/master) &&
> +	test "$master_master" = "$mirror_master"
> +
> +'

I am quite puzzled by this and many other "does not" in the test
description.  The --mirror option is advertised as

 - newly created will be pushed;
 - locally updated will be force pushed;
 - locally deleted will be removed.

which makes sense as we do want these things to happen for
"mirrors".  Indeed the above updates master branch at the master
repository and makes sure that change is propagated to the
mirror repository.  The description should read "push mirror
creates new branches" shouldn't it?
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux