On Fri, 16 Aug 2024 at 23:25, Chandra Pratap
<chandrapratap3519@xxxxxxxxx> wrote:
>
> In the current testing setup, block operations are left unexercised
> for obj blocks. Add a test that exercises these operations for obj
> blocks.
>
> Mentored-by: Patrick Steinhardt <ps@xxxxxx>
> Mentored-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
> Signed-off-by: Chandra Pratap <chandrapratap3519@xxxxxxxxx>
> ---
> t/unit-tests/t-reftable-block.c | 82 +++++++++++++++++++++++++++++++++
> 1 file changed, 82 insertions(+)
>
> diff --git a/t/unit-tests/t-reftable-block.c b/t/unit-tests/t-reftable-block.c
> index 1256c7df6a..7671a40969 100644
> --- a/t/unit-tests/t-reftable-block.c
> +++ b/t/unit-tests/t-reftable-block.c
> @@ -190,9 +190,91 @@ static void t_log_block_read_write(void)
> reftable_record_release(&recs[i]);
> }
>
> +static void t_obj_block_read_write(void)
> +{
> + const int header_off = 21;
> + struct reftable_record recs[30];
> + const size_t N = ARRAY_SIZE(recs);
> + const size_t block_size = 1024;
> + struct reftable_block block = { 0 };
> + struct block_writer bw = {
> + .last_key = STRBUF_INIT,
> + };
> + struct reftable_record rec = {
> + .type = BLOCK_TYPE_OBJ,
> + };
> + size_t i = 0;
> + int ret;
> + struct block_reader br = { 0 };
> + struct block_iter it = BLOCK_ITER_INIT;
> + struct strbuf want = STRBUF_INIT;
> +
> + REFTABLE_CALLOC_ARRAY(block.data, block_size);
> + block.len = block_size;
> + block.source = malloc_block_source();
> + block_writer_init(&bw, BLOCK_TYPE_OBJ, block.data, block_size,
> + header_off, hash_size(GIT_SHA1_FORMAT_ID));
> +
> + for (i = 0; i < N; i++) {
> + uint8_t bytes[] = { i, i + 1, i + 2, i + 3, i + 5 }, *allocated;
> + allocated = reftable_malloc(ARRAY_SIZE(bytes));
> + DUP_ARRAY(allocated, bytes, ARRAY_SIZE(bytes));
The second line of this loop is redundant and causes a memory leak
in the GitHub CI. I'll fix this in the next iteration.
---snip---
