On Thu, Aug 15, 2024 at 04:37:26PM -0500, Justin Tobler wrote: > On 24/08/15 10:00AM, Patrick Steinhardt wrote: > > - repo_set_hash_algo(the_repository, repo_fmt.hash_algo); > > - repo_set_ref_storage_format(the_repository, repo_fmt.ref_storage_format); > > + repository_format_configure(&repo_fmt, hash, ref_storage_format); > > Overall, I like that this repostory format configuration is under > `repository_format_configure()`. The `validate_*()` functions names > confused me slightly initially because I assumed they were only > validating, but they also configure the repo format. Looking good :) Yeah, agreed. We _did_ validate whether the new configuration makes sense, but that wasn't really the main thing those functions did. Patrick
