On Thu, Aug 15, 2024 at 03:24:21PM +1000, James Liu wrote: > On Tue Aug 13, 2024 at 5:17 PM AEST, Patrick Steinhardt wrote: > > @@ -206,7 +224,7 @@ struct maintenance_run_opts { > > enum schedule_priority schedule; > > }; > > > > -static int pack_refs_condition(void) > > +static int pack_refs_condition(UNUSED struct gc_config *cfg) > > { > > /* > > * The auto-repacking logic for refs is handled by the ref backends and > > @@ -216,7 +234,8 @@ static int pack_refs_condition(void) > > return 1; > > } > > > > -static int maintenance_task_pack_refs(MAYBE_UNUSED struct maintenance_run_opts *opts) > > +static int maintenance_task_pack_refs(MAYBE_UNUSED struct maintenance_run_opts *opts, > > + UNUSED struct gc_config *cfg) > > { > > struct child_process cmd = CHILD_PROCESS_INIT; > > > > Are we defining *cfg as an unused argument to conform to the > `maintenance_task_fn` signature? Yup, that's exactly it. Patrick