On Wed, Aug 14, 2024 at 04:13:05PM +0100, Phillip Wood wrote: > On 14/08/2024 05:15, Patrick Steinhardt wrote: > > On Tue, Aug 13, 2024 at 02:19:20PM +0100, Phillip Wood wrote: > > > On 13/08/2024 12:59, Patrick Steinhardt wrote: > > > > > > Oh, I misunderstood what this patch is changing. So despite being tagged > > > builtin/maintenance and talking about "git maintenance" it does not actually > > > touch builtin/maintenance.c or change its behavior. What it is actually > > > doing is changing how other git commands run "git maintenance --auto" so > > > that it is always run in the background unless the user configures > > > maintenance.autoDetach=false. That sounds like a good change. > > > > > > Thanks for clarifying > > Sorry my message sounds grumpier than I intended. No worries, I didn't receive it as grumpy. > > Yes. I should've probably prefixed this with "run-command:", not with > > "builtin/maintenance". > > That's a good idea, I think the important thing we want to convey is that > we're changing the way we run "git maintenance --auto", not the behavior of > "git maintenance" itself. I'll have a look in case I need to reroll this series. Patrick
