From: Jacob Keller <jacob.keller@xxxxxxxxx> The set of aliases used for the pine --dump-aliases test do not perfectly mesh with the way the pine address book is defined. While technically all valid, there are some oddities including bob's name being partially split so that the actual address is returned as "Bobbyton <bob@xxxxxxxxxxx". A strict reading of the pine documentation indicates that the address should either be of the form "address@domain" or a comma separated list of address, name/address pairs, or other aliases enclosed by (). The parsing implementation in git-send-email is not as strict, but it makes sense to ensure the test data used is. Although the --dump-aliases test does not make use of the address data, it is helpful to avoid giving future developers the wrong impression of the file format. Also add an alias which translates to multiple addresses using the () format. Signed-off-by: Jacob Keller <jacob.keller@xxxxxxxxx> --- t/t9001-send-email.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index aa36ace393b7..c96d6955b9f2 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -2093,13 +2093,15 @@ test_dump_aliases '--dump-aliases mailrc format' \ test_dump_aliases '--dump-aliases pine format' \ 'pine' \ 'alice' \ + 'bcgrp' \ 'bob' \ 'chloe' \ 'eve' <<-\EOF - alice Alice W Land <awol@xxxxxxxxxxx> - eve Eve <eve@xxxxxxxxxxx> - bob Robert Bobbyton <bob@xxxxxxxxxxx> + alice Alice W Land awol@xxxxxxxxxxx Friend + eve Eve eve@xxxxxxxxxxx + bob Robert Bobbyton bob@xxxxxxxxxxx chloe chloe@xxxxxxxxxxx + bcgrp (bob, chloe, Other <o@xxxxxxxxxxx>) EOF test_dump_aliases '--dump-aliases gnus format' \ -- 2.46.0.124.g2dc1a81c8933
