The reftable library comes with self tests, which are exercised as part of the usual end-to-end tests and are designed to observe the end-user visible effects of Git commands. What it exercises, however, is a better match for the unit-testing framework, merged at 8bf6fbd0 (Merge branch 'js/doc-unit-tests', 2023-12-09), which is designed to observe how low level implementation details, at the level of sequences of individual function calls, behave. Hence, port reftable/readwrite_test.c to the unit testing framework and improve upon the ported test. The first patch in the series moves the test to the unit testing framework, and the rest of the patches improve upon the ported test. Mentored-by: Patrick Steinhardt <ps@xxxxxx> Mentored-by: Christian Couder <chriscool@xxxxxxxxxxxxx> Signed-off-by: Chandra Pratap <chandrapratap3519@xxxxxxxxx> --- Changes in v3: - Order the header files alphabetically in t/unit-tests/t-reftable-readwrite.c in patch 1. - use check_char() and check_int() instead of check() at two instances in patch 1. - #include 'reftable/basics.h' in patch 2 when introducing free_names() in the test file. CI/PR: https://github.com/gitgitgadget/git/pull/1770 Chandra Pratap(4): t: move reftable/readwrite_test.c to the unit testing framework t-reftable-readwrite: use free_names() instead of a for loop t-reftable-readwrite: use 'for' in place of infinite 'while' loops t-reftable-readwrite: add test for known error Makefile | 2 +- reftable/reftable-tests.h | 1 - t/helper/test-reftable.c | 1 - reftable/readwrite_test.c => t/unit-tests/t-reftable-readwrite.c | 441 +++++++++++++++++++++++----------------- 4 files changed, 219 insertions(+), 226 deletions(-) Range-diff against v2: 1: 0ebe76c331 ! 1: 03b946434e t: move reftable/readwrite_test.c to the unit testing framework @@ t/unit-tests/t-reftable-readwrite.c: license that can be found in the LICENSE fi -#include "reftable-tests.h" -#include "reftable-writer.h" +#include "test-lib.h" -+#include "reftable/reader.h" +#include "reftable/blocksource.h" ++#include "reftable/reader.h" +#include "reftable/reftable-error.h" +#include "reftable/reftable-writer.h" @@ t/unit-tests/t-reftable-readwrite.c: static void write_table(char ***names, stru - EXPECT(buf->buf[off] == 'r'); + if (!off) + off = header_size((hash_id == GIT_SHA256_FORMAT_ID) ? 2 : 1); -+ check(buf->buf[off] == 'r'); ++ check_char(buf->buf[off], ==, 'r'); } - EXPECT(stats->log_stats.blocks > 0); -+ check(stats->log_stats.blocks > 0); ++ check_int(stats->log_stats.blocks, >, 0); reftable_writer_free(w); } 2: a148702451 ! 2: e23a515736 t-reftable-readwrite: use free_names() instead of a for loop @@ Commit message Signed-off-by: Chandra Pratap <chandrapratap3519@xxxxxxxxx> ## t/unit-tests/t-reftable-readwrite.c ## +@@ t/unit-tests/t-reftable-readwrite.c: license that can be found in the LICENSE file or at + */ + + #include "test-lib.h" ++#include "reftable/basics.h" + #include "reftable/blocksource.h" + #include "reftable/reader.h" + #include "reftable/reftable-error.h" @@ t/unit-tests/t-reftable-readwrite.c: static void t_table_read_api(void) struct reftable_reader rd = { 0 }; struct reftable_block_source source = { 0 }; 3: ee15af6631 = 3: 9194a4055a t-reftable-readwrite: use 'for' in place of infinite 'while' loops 4: 3f571c09e2 = 4: d34b01fad8 t-reftable-readwrite: add test for known error
