Patrick Steinhardt <ps@xxxxxx> writes: > Hi, > > this patch series performs some simplification of the reftable library > by dropping the generic `reftable_table` interface. The intent of this > interface is to abstract away whether the underlying table is either a > single reftable, or a merged reftable. Arguably though, it is not needed > anymore starting with my recent refactorings [1] that made the reftable > iterator itself seekable, as that now provides such a generic interface > already. > > So this patch series rips out the `reftable_table` interface, both to > remove unused clutter, but more importantly to make the reftable library > easier to understand overall. There is also a tiny performance gain of > 1-3% by requiring one less vtable function call. But while that speedup > is consistent, I didn't include any benchmarks as it is rather close to > noise and not the primary motivation of this patch series. > > Patrick > This is a very welcome change, the indirection was a cause for confusion before and this clears it up. My only concern is the loss of dumping reftables for debug purposes in patch 8, I suggest we keep them until we have alternatives. Apart from that everything looks great. Thanks!
Attachment:
signature.asc
Description: PGP signature
