On Wed, Aug 07, 2024 at 09:59:39AM -0700, Junio C Hamano wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > The series is built on top of 406f326d27 (The second batch, 2024-08-01) > > with ps/leakfixes-part-3 at f30bfafcd4 (commit-reach: fix trivial memory > > leak when computing reachability, 2024-08-01) merged into it. > > A quick question. Is it on your radar that transport_get() leaks > the helper name when "foo::bar" is given as a remote? > > https://github.com/git/git/actions/runs/10274435719/job/28431161208#step:5:893 > > If not, I'll handle it separately, whose fix should look something > like the attached. > > Thanks. Yeah, it's in part 5 [1], 97613b9cb9 (transport-helper: fix leaking helper name, 2024-05-27). Feel free to handle it separately though, I'll wait for part 4 to land first anyway, which likely takes a couple of days. Patrick [1]: https://gitlab.com/gitlab-org/git/-/tree/pks-leak-fixes-pt5
Attachment:
signature.asc
Description: PGP signature
