On Nov 9, 2007 7:04 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > "David Symonds" <dsymonds@xxxxxxxxx> writes: > > > Looking at the existing tests which, when they change directories, > > don't cd back to where they were; they "cd .." at the start of the > > next test. I'll add a "cd .." to the relevant bits of my tests. > > Do not follow the bad examples, please. So what would you prefer? Bracketing the whole test in parentheses looks ugly, but I can do that if that's the only option. If I look at t5510-fetch.sh (one of yours, Junio), there is no directory restoration in the case of test failure, as in my original patch. Perhaps test_ok_ and test_failure_ in test-lib.sh should restore the directory? Dave. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
