On Thu, Aug 01, 2024 at 11:11:21PM +0800, shejialuo wrote: > Hi All, > > This version does the following things: > > 1. By following the advice from Patrick, we should make the callback > function be generic by adding only one "void * fsck_report" parameter. > Thus the commit sequence will be much more clearer. And it wll be much > easier for reviewers to review. And I have split the commit into more > commits in this version. > 2. Enhance the commit messages to provide more context about why we > should do this. > 3. Patrick advices that we should initialize the "fsck_options" member > when parsing the options. However, because the original "strict" and > "verbose" field are defined as the bit field, we cannot take the address > of them. So I simply remove the bit field. > 4. As Patrick said, ".lock" should not be reported as error. At current, > ignore files ending with ".lock". > 5. Add a fsck msg type called "badRefFiletype" which indicates that a > ref has a bad file type when scanning the directory. > 6. Junio advices instead of using "fsck_refs_fns", we should use the > singular version "fsck_refs_fn", fix this. > 7. Drop the last patch because in this series, we mainly focus on the > infra, I will add a series later to add ref content check. > > However, there is one thing holding. Junio advices that I should > follow the Patrick's change to change the prototype of "files_fsck_refs_fn" > > https://lore.kernel.org/git/fe0e2c3617c8040c632dbc3de613a1d22e8070f7.1722316795.git.ps@xxxxxx/ > > However, at current, this patch is not in the cooking tree. I will > handle this later. This looks very good to me. I've got another set of smallish nits, but all of those should be quick to address, I think. I think that the next version should likely be ready to go. Thanks! Patrick
Attachment:
signature.asc
Description: PGP signature
