On Thu, Aug 01, 2024 at 07:07:22AM -0400, Jeff King wrote: > > The tests explicitly exercising the new incremental MIDX feature are > > relatively limited for two reasons: > > > > 1. Most of the "interesting" behavior is already thoroughly covered in > > t5319-multi-pack-index.sh, which handles the core logic of reading > > objects through a MIDX. > > > > The new tests in t5334-incremental-multi-pack-index.sh are mostly > > focused on creating and destroying incremental MIDXs, as well as > > stitching their results together across layers. > > Do you mean here that t5319 will get coverage when > GIT_TEST_MULTI_PACK_INDEX_WRITE_INCREMENTAL is set? In the long run, I > wonder if we should pull t5319's tests into lib-midx.sh and run them in > incremental and non-incremental modes. I don't know. Part of me thinks that that would be a good idea, but part of me also thinks that it would be (a) painful (since many of those tests assume that exactly one MIDX exists in the repository before/during/after each test), and (b) not particularly useful (since much of the interesting behavior occurs when multiple MIDXs contain packs with overlapping objects, see (a)). Thanks, Taylor
