On Thu, Aug 01, 2024 at 04:29:41PM +0530, Chandra Pratap wrote: > The reftable library comes with self tests, which are exercised > as part of the usual end-to-end tests and are designed to > observe the end-user visible effects of Git commands. What it > exercises, however, is a better match for the unit-testing > framework, merged at 8bf6fbd0 (Merge branch 'js/doc-unit-tests', > 2023-12-09), which is designed to observe how low level > implementation details, at the level of sequences of individual > function calls, behave. > > Hence, port reftable/pq_test.c to the unit testing framework and > improve upon the ported test. The first two patches in the series > are preparatory cleanup, the third patch moves the test to the unit > testing framework, and the rest of the patches improve upon the > ported test. > > Mentored-by: Patrick Steinhardt <ps@xxxxxx> > Mentored-by: Christian Couder <chriscool@xxxxxxxxxxxxx> > Signed-off-by: Chandra Pratap <chandrapratap3519@xxxxxxxxx> > > --- > Changes in v7: > - Fix a typo in patch 1 > - Fix do-while style error in patch 6 and 7 The range-diff looks as expected to me, so the whole series LGTM now. Thanks! Patrick
Attachment:
signature.asc
Description: PGP signature
