On Tue, Jul 30, 2024 at 10:31:32AM +0200, Patrick Steinhardt wrote: > On Mon, Jul 29, 2024 at 09:27:02PM +0800, shejialuo wrote: > > The interfaces defined in the `ref_storage_be` are carefully structured > > in semantic. It's organized as the five parts: > > > > 1. The name and the initialization interfaces. > > 2. The ref transaction interfaces. > > 3. The ref internal interfaces (pack, rename and copy). > > 4. The ref filesystem interfaces. > > 5. The reflog related interfaces. > > > > To keep consistent with the git-fsck(1), add a new interface named > > "fsck_refs_fn" to the end of "ref_storage_be". This semantic cannot be > > grouped into any above five categories. Explicitly add blank line to > > make it different from others. > > > > Last, implement placeholder functions for each ref backends. > > You're carefully explaining what you are doing and where you are placing > the new callback functions. But you never explain why you add those > functions in the first place, which I would think is much more important > than explaining the placement of the new callbacks. > Thanks, I will improve this in the next version. > Other than that this patch looks good to me. > > Patrick
