On Mon, 29 Jul 2024 14:37:35 -0700, Junio C Hamano wrote: ... > I am tempted to squash in > > diff --git i/t/t3301-notes.sh w/t/t3301-notes.sh > index c0dbacc161..99137fb235 100755 > --- i/t/t3301-notes.sh > +++ w/t/t3301-notes.sh > @@ -1559,7 +1559,12 @@ test_expect_success 'empty notes are displayed by git log' ' > > test_expect_success 'empty notes do not invoke the editor' ' > test_commit 18th && > - GIT_EDITOR="false" git notes add -C "$empty_blob" --allow-empty > + GIT_EDITOR="false" git notes add -C "$empty_blob" --allow-empty && > + git notes remove HEAD && > + GIT_EDITOR="false" git notes add -m "" --allow-empty && > + git notes remove HEAD && > + GIT_EDITOR="false" git notes add -F /dev/null --allow-empty && > + git notes remove HEAD > ' > > test_done > > to make sure that all three options mentioned in the proposed commit > log message are tested. It is not too much more effort to do so. This looks good and works for me - feel free to squash it in. Thanks, David
