Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: >> + mkdir dir2 && >> + echo bonjour > dir2/file2 && >> + git add dir2/file2 && >> + git commit -m "populate tree" >> + >> +' > > Please lose the empty line before the closing quote. (This applies to all > tests.) I personaly find the extra blank lines before and after the indented test body easier to read. That is.. test_expect_sucess 'test description comes here' ' test command 1 && test command 2 && ... test command N ' I agree with all other suggestions from your message. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html