Karthik Nayak <karthik.188@xxxxxxxxx> writes: >> diff --git a/transport.c b/transport.c >> index 12cc5b4d96..1a7d86fa40 100644 >> --- a/transport.c >> +++ b/transport.c >> @@ -1536,7 +1536,7 @@ int transport_fetch_refs(struct transport *transport, struct ref *refs) >> return rc; >> } >> >> -int transport_get_remote_bundle_uri(struct transport *transport) >> +static int transport_get_remote_bundle_uri(struct transport *transport) >> > > Why make it static? The reason is rather well described in the proposed log message, I think. >> + * bundle URI(s) are received from the server. >> + * Populates "struct transport"'s "bundles" and "got_remote_bundle_uri". >> */ >> -int transport_get_remote_bundle_uri(struct transport *transport); >> +int transport_has_remote_bundle_uri(struct transport *transport); >> > > Shouldn't this now be renamed to `transport_has_bundle_uri`? Earlier, we > were 'getting' bundle URIs from the remote. Now, we are abstracting that > away and simply asking, 'do we have bundle URIs'. A good question.
