On Fri, Jul 26, 2024 at 06:27:14AM +0000, Haritha via GitGitGadget wrote: > From: D Harithamma <harithamma.d@xxxxxxx> > > When Git adds a file requiring encoding conversion and tracing of encoding > conversion is not requested via the GIT_TRACE_WORKING_TREE_ENCODING > environment variable, the `trace_encoding()` function still allocates & > prepares "human readable" copies of the file contents before and after > conversion to show in the trace. This results in a high memory footprint > and increased runtime without providing any user-visible benefit. > > This fix introduces an early exit from the `trace_encoding()` function > when tracing is not requested, preventing unnecessary memory allocation > and processing. > > Signed-off-by: Harithamma D <harithamma.d@xxxxxxx> > --- > Fix to avoid high memory footprint > This head line > Fix to avoid high memory footprint does not tell to much when and how it happens. The word "fix" is not realy needed (in this project). Something like "convert: avoid high memory footprint" will tell the reader, that only the convert functionality is affected by this patch. Thinking about it, another suggestion may be: convert: Reduce memory allocation when trace_encoding() is not used If someone browses through the whole history of Git, this is easier to follow. The exact wording may be improved, important would be to have "convert:" as the first keyword, and then "memory allocation" and "trace_encoding()" give hints, what this is all about in one line. And the rest looks good.
