On Thu, Jul 25, 2024 at 08:28:58AM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > >> A command with a name along the lines of `git diagnose`, I'd say. > > > > OK. I don't really care much either way how it is spelled, though my > > inclination is that we already have a confusing number of commands and > > should avoid adding more. > > I think what you are responding to is an oblique reference to a > command that already exists, and there is no need to worry about > adding more ;-). If "bugreport" is not farming out the task of > collecting the information to it, "bugreport" need to be corrected > to do so (while "diagnose" may have to learn to collect more, if > "bugreport" collects things that "diagnose" does not (yet)). Oh, sorry, I somehow missed when diagnose was added. Yeah, that seems like a perfectly reasonable place to put it, though like bugreport it has the same annoyance that I just want to dump the info to stdout, not make a zipfile. Curiously, it seems to segfault for me when run outside a repository. :-/ The issue is a NULL the_repository->objects->odb pointer passed into dir_file_stats(). But obviously that bug is orthogonal to the discussion here. -Peff
