This patchset attempts to revert editor invocation behavior for empty notes, which was inadvertantly changed via 90bc19b3ae ("notes.c: introduce '--separator=<paragraph-break>' option"). The new test passes prior to 90bc19b3ae and after this fix. Please cc me in any replies as I'm not subscribed. Cheers, David -- The following changes since commit ad57f148c6b5f8735b62238dda8f571c582e0e54: Git 2.46-rc2 (2024-07-23 16:54:35 -0700) are available in the Git repository at: https://github.com/ddiss/git.git notes_empty_editor_add for you to fetch changes up to fa40003e560348e146f11aa85ac1fc5a3d86e31e: notes: revert note_data.given behavior with empty notes add (2024-07-25 15:41:56 +0200) ---------------------------------------------------------------- David Disseldorp (2): t3301-notes: check editor isn't invoked for empty notes add notes: revert note_data.given behavior with empty notes add builtin/notes.c | 5 +++-- t/t3301-notes.sh | 5 +++++ 2 files changed, 8 insertions(+), 2 deletions(-)