Re: [PATCH v2 0/2] add-p P fixups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rubén

On 24/07/2024 17:12, Rubén Justo wrote:
On Wed, Jul 24, 2024 at 04:21:53PM +0100, phillip.wood123@xxxxxxxxx wrote:

That was my initial thought [*1*] when the problem with "dash
0.5.10.2-6" appeared.

Junio proposed [*2*] documenting the changes to address it as a separate
patch, and I think it makes sense and it is valuable to capture the
situation this way in the history.

We normally avoid merging commits that are known to break our ci. We can add a comment about the dash problem to the commit message when this fixup is squashed. Also the problem is now documented in Documentation/CodingGuidelines which is more likely to be read by other contributors.

Regarding the bisectability, I don't understand what stops from being
bisectable.  Except in a scenario with a shell like "dash 0.5.10.2-6"
there won't be any problem.

But we know that shell is in use in a popular Linux distribution so it is a problem for those users.

Best Wishes

Phillip

And in one with it, which should be
uncommon, the situation is well explained.

So, I dunno.

    1.- 2b57479c-29c8-4a6e-b7b0-1309395cfbd9@xxxxxxxxx

    2.- xmqq7cdd9l0m.fsf@gitster.g




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux