On Wed, Jul 24, 2024 at 11:40 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > "Jin, Di" <di_jin@xxxxxxxxx> writes: > > We discovered that re-init with option --separate-git-dir will throw > > an EXDEV when the target directory is not on the same file system as > > the original directory. > > Yup, it is hitting the limitation of your filesystem. The code > wants to move the original .git directory together with its contents > to a new place, and it makes a single rename() system call to do so. > [...] > The code path could probably borrow some code to recursively "copy" > directory from the local "git clone" code path, and then invent a > new code to recursively remove the original ".git", and trigger that > new code when rename() fails. Re-init with --separate-git-dir isn't the only problem spot. `git worktree move` also suffers the same problem for the same reason. > But at that point, only as a fall-back measure, it might be simpler > and much less error prone to spawn a "mv src dst" as a subprocess > using the run_command() API. This wouldn't help Windows users. > It would make a good bite-sized #leftoverbits project for aspiring > new Git contributors. Any takers? ;-) It might be a bit more than bite-sized, though, considering the above points about `git worktree move` also needing such a fix, and having to deal with Microsoft Windows.
