On Mon, Jul 22, 2024 at 02:25:45PM -0700, Junio C Hamano wrote: > Rubén Justo <rjusto@xxxxxxxxx> writes: > > > To fix the test, as already said, we need this: > > > > test_write_lines P q | > > ( > > GIT_PAGER="head -n 1" && > > export GIT_PAGER && > > test_terminal git add -p >actual > > ) > > This took sufficiently large amount of collective braincycles, and > it would be worth documenting as a separate patch, I would suspect. > > Something along the following lines, but please take the authorship > *and* give it a better explanation. Here's an attempt. I'm also adding the change for `wait_for_pager`, which could be squashed in b29c59e3d2 (pager: introduce wait_for_pager, 2024-07-16). Although, highlighted I think it's interesting as well. But I don't have a strong preference. This builds on rj/add-p-pager. Thanks. Rubén Justo (2): t3701: avoid one-shot export for shell functions pager: make wait_for_pager a no-op for "cat" pager.c | 3 +++ t/t3701-add-interactive.sh | 6 +++++- 2 files changed, 8 insertions(+), 1 deletion(-) base-commit: 6bc52a5543008bff2c6ec7a0a935c7fc1f79e646 -- 2.45.1
