On Nov 8, 2007 7:30 PM, Junio C Hamano <junio@xxxxxxxxx> wrote: > > Have you tested this patch from the toplevel of any tree, where > "git-rev-parse --show-cdup" would yield an empty string? No, I didn't. Arguably, "git-rev-parse --show-cdup" should always return a path to the top-level, which would make this kind of construction much simpler. Is there anything that relies upon it returning the empty string when you're in the top-level directory? > I also wonder how this patch (with an obvious fix to address the > above point) would interact with GIT_DIR and/or GIT_WORK_TREE in > the environment. No idea. I'm still learning my way around the git codebase, so I was hoping for some review and feedback from more experienced Gits. Dave. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html