On 17/07/2024 23:53, Junio C Hamano wrote: [snip] > That's OK. So in short, with a separate SP_EXTRA_FLAGS with "-Wno-vla", > Luc's patch is a sufficient fix without any downsides, no? > Yes, assuming you're only concerned with 'make sparse' usage. BTW, I didn't expect it to take this long for this issue to come back to the list! I expected it to almost immediately cause problems with the sparse ci job, when the version of Ubuntu was updated to the LTS (now previous LTS!). So, I just found a simple solution for now (which turned into 2 years). ATB, Ramsay Jones