"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: >> Johannes Schindelin (7): >> run-command: refactor getting the Unix shell path into its own >> function >> strvec: declare the `strvec_push_nodup()` function globally >> win32: override `fspathcmp()` with a directory separator-aware version >> mingw(is_msys2_sh): handle forward slashes in the `sh.exe` path, too >> run-command(win32): resolve the path to the Unix shell early >> run-command: declare the `git_shell_path()` function globally >> var(win32): do report the GIT_SHELL_PATH that is actually used > > This series seems reasonable to me as well. I of course can't speak to > whether the approach for finding sh is the right one, since I'm not a > Windows developer, but I have confidence you know the answer and have > thought through it fully. ... and the series will be in 2.46-rc1 Thanks.
