On 17/07/2024 15:48, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > >> On Tue, Jul 16, 2024 at 08:45:48PM +0100, Ramsay Jones wrote: >> >>> error: could not link file '.git/ref_migration.sr9pEF/reftable' to '.git/reftable': Permission denied >>> migrated refs can be found at '.git/ref_migration.sr9pEF' >>> [...] >>> Now try to finish the migration by hand: >>> >>> $ mv .git/ref_migration.sr9pEF/reftable .git/reftable >>> >>> Hmm, note no error; of course, the mv command may well do much more than >>> the rename() library function, so they are not necessarily equivalent. >> >> This is a shot in the dark, but: could the problem be an open file that >> cannot be moved? If I run a "ref migrate" on my Linux system in the >> debugger and stop at move_files(), checking /proc/<pid>/fd shows an open >> descriptor for .git/ref_migration.WnJ8TS/reftable/tables.list. > > Hmph, I wonder ifthat means the same test should be failing on > Windows, too? > Since we have not heard anything from Gfw, I had assumed it was cygwin specific (Gfw uses mingw_rename() not rename() so we should not necessarily expect it to behave the same). However, Jeff's patch fixes the problem for me (see other email). ATB, Ramsay Jones
