Make the test name more descriptive and avoid unnecessary redirection. Thanks. Rubén Justo (4): add-patch: test for 'p' command pager: do not close fd 2 unnecessarily pager: introduce wait_for_pager add-patch: render hunks through the pager add-patch.c | 18 ++++++++++++--- pager.c | 45 +++++++++++++++++++++++++++++++++----- pager.h | 1 + t/t3701-add-interactive.sh | 44 +++++++++++++++++++++++++++++++++++++ 4 files changed, 100 insertions(+), 8 deletions(-) Interdiff against v3: diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh index 2ac860cc42..c60589cb94 100755 --- a/t/t3701-add-interactive.sh +++ b/t/t3701-add-interactive.sh @@ -612,11 +612,11 @@ test_expect_success TTY 'print again the hunk (PAGER)' ' test_cmp expect actual.trimmed ' -test_expect_success TTY 'P does not break if pager ends unexpectedly' ' +test_expect_success TTY 'P handles SIGPIPE when writing to pager' ' test_when_finished "rm -f huge_file; git reset" && printf "\n%2500000s" Y >huge_file && git add -N huge_file && - test_write_lines P q | GIT_PAGER="head -n 1" test_terminal git add -p >actual + test_write_lines P q | GIT_PAGER="head -n 1" test_terminal git add -p ' test_expect_success 'split hunk "add -p (edit)"' ' -- 2.46.0.rc0.4.g229d67bbd7
