On Tue, Jul 9, 2024 at 12:37 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Toon claes <toon@xxxxxxxxx> writes: > > >> + temp_ref->old_oid = *(transport->smart_options->object_info_oids->oid + i); > > > > Any reason why you're not using the subscript operator (square brackets) > > like this: > > > > + temp_ref->old_oid = transport->smart_options->object_info_oids->oid[i]; > > Much nicer, but fold such overly long lines, please, > > temp_ref->old_oid = transport->smart_options-> > object_info_oids->oid[i]; > > to make them readable. > > Thank you, sir. I will follow the folding format in V2. > > > ... > > To be honest, I'm not sure it works, because fetch_object_info() always > > seem to return a non-zero value. I'm not sure this is due to missing > > code coverage, or a bug. I guess it's worth looking into.
