On Thu, Nov 08, 2007 at 07:09:29AM +0000, Junio C Hamano wrote: > The 'automagic parseopt' support corrupted non option parameters > that had IFS characters in them. The worst case can be seen > when it has a non option parameter like this: > > $1=" * some string blech" > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > - parseopt_extra= > - [ -n "$OPTIONS_KEEPDASHDASH" ] && > - parseopt_extra="$parseopt_extra --keep-dashdash" > + [ -n "$OPTIONS_KEEPDASHDASH" ] && parseopt_extra="--keep-dashdash" oh and this part is wrong because you're affected by $parseopt_extra environment poisonning. And you have to fix git-clone.sh that uses git-rev-parse --parsopt directly with the same call too (as it doesn't use git-sh-setup). -- ·O· Pierre Habouzit ··O madcoder@xxxxxxxxxx OOO http://www.madism.org
Attachment:
pgp6BHLA1k3MI.pgp
Description: PGP signature
