On Tue, Jul 09, 2024 at 05:11:36PM -0500, Justin Tobler wrote: > On 24/07/09 08:35PM, shejialuo wrote: > > The interfaces defined in the `ref_storage_be` are carefully structured > > in semantic. It's organized as the five parts: > > > > 1. The name and the initialization interfaces. > > 2. The ref transaction interfaces. > > 3. The ref internal interfaces (pack, rename and copy). > > 4. The ref filesystem interfaces. > > 5. The reflog related interfaces. > > > > To keep consistent with the git-fsck(1), add a new interface named > > "fsck_refs_fn" to the end of "ref_storage_be". This semantic cannot be > > grouped into any above five categories. Explicitly add blank line to > > make it different from others. > > In this patch we are not only adding the `fsck` infrastructure to > `ref_storage_be`, but also wiring what are essentially no-op functions > to the various implementations. It might be good to mention this in the > commit message so it is better understood that future patches will > actually provide proper function implementations. > Yes, I agree. I will improve this in the next version. > -Justin
