Re: [PATCH v4] doc: fix the max number of git show-branches shown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 07, 2024 at 02:28:31AM +0000, Rikita Ishikawa via GitGitGadget wrote:

> From: Rikita Ishikawa <lagrange.resolvent@xxxxxxxxx>
> 
> The number to be displayed is calculated by the
> following defined in object.h.
> 
> ```
>   #define REV_SHIFT        2
>   #define MAX_REVS        (FLAG_BITS - REV_SHIFT)
> ```
> 
> FLAG_BITS is currently 28, so 26 is the correct
> number.
> 
> Signed-off-by: Rikita Ishikawa <lagrange.resolvent@xxxxxxxxx>
> ---

Thanks, this version looks pretty good to me.

One minor nit: commit messages are not actually markdown (even when
rendered on GitHub), so your ``` block delimiters are a bit unusual.
We'd usually just rely on the indentation and blank lines to show the
structure.

-Peff




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux