Am 02.07.24 um 17:51 schrieb Junio C Hamano: > phillip.wood123@xxxxxxxxx writes: > >>> @@ -156,6 +163,7 @@ extern union test__tmp test__tmp[2]; >>> int test__run_begin(void); >>> __attribute__((format (printf, 3, 4))) >>> int test__run_end(int, const char *, const char *, ...); >> >> We should add >> >> __attribute__((format (printf, 2, 3), warn_unused_result)) >> >> here to catch any errors in the format string / arguments and to warn >> if TEST_RUN() isn't wrapped in an if() statement. > > Nice. Especially the "unused" check is valuable. This confused me for a moment. I assume you both mean the new function test__run, whose addition was cut from the citation: +int test__run(const char *location, const char *format, ...); For that one the numbers make sense and the idea is good. :) René
