Karthik Nayak <karthik.188@xxxxxxxxx> writes: > Hello, > > Chandra Pratap <chandrapratap3519@xxxxxxxxx> writes: > >> In the recent codebase update (commit 8bf6fbd, 2023-12-09), a new unit >> testing framework written entirely in C was introduced to the Git project >> aimed at simplifying testing and reducing test run times. >> Currently, tests for the reftable refs-backend are performed by a custom >> testing framework defined by reftable/test_framework.{c, h}. Port >> reftable/record_test.c to the unit testing framework and improve upon >> the ported test. >> >> The first patch in the series moves the test to the unit testing framework, >> and the rest of the patches improve upon the ported test. >> >> Mentored-by: Patrick Steinhardt <ps@xxxxxx> >> Mentored-by: Christian Couder <chriscool@xxxxxxxxxxxxx> >> Signed-off-by: Chandra Pratap <chandrapratap3519@xxxxxxxxx> >> >> --- >> Changes in v4: >> - Rename the tests to follow a 't_foo()' pattern instead >> of 'test_foo()' >> - Use hard-coded test input in the 10th and 11th patch >> > > Nice, I see my comments from the previous versions are addressed. It > looks good to me now! Thanks, both.