Hi René
On 01/07/2024 21:04, René Scharfe wrote:
Am 01.07.24 um 21:49 schrieb Josh Steadmon:
On 2024.06.29 17:44, René Scharfe wrote:
Use the macro TEST_RUN instead of the internal functions
test__run_begin() and test__run_end().
Signed-off-by: René Scharfe <l.s.r@xxxxxx>
Nitpick: please expand the commit message here as you did for the
following patches.
There is not much more to it: Use of internal functions is discouraged,
so this patch replaces their calls with the new public feature. Perhaps
a "Kinda-requested-by: Phillip Wood <phillip.wood@xxxxxxxxxxxxx>" would
be appropriate?
Perhaps something like
These tests use the internal functions test__run_begin() and
test__run_end() which are supposed to be private to the test framework.
Convert them to use the newly added TEST_RUN() instead.
would be sufficient?
Best Wishes
Phillip
Unlike in the later patches the tests themselves are unchanged, so this
has no consequence for people that want to add or modify character
classifier tests.
René
