Josh Steadmon <steadmon@xxxxxxxxxx> writes: >> This version addresses Phillip's review about detecting duplicates in >> oidmap when iterating over it and removing put_and_check_null() to move >> the relevant code to setup() instead. And contains some grammer fixes >> in the comment. > > IIUC this corrects all of the issues that Phillip noted in his earlier > review, except for checking for duplicates, is that right? There is an attempted duplicate checking during iteration; the test data source key_val[] array is (ab)used to record the already seen keys during the iteration, which would work but is a hacky and unmaintainable way to do so. Thanks for reviewing.
