On 2024.06.29 17:33, René Scharfe wrote: > The macro TEST only allows defining a test that consists of a single > expression. This requires wrapping tests made up of one or more > statements in a function, which is a small, but avoidable hurdle. This > series provides a new macro, TEST_RUN, that provides a way to define > tests without requiring to declare a function. > > t0080: move expected output to a file > unit-tests: add TEST_RUN > t-ctype: use TEST_RUN > t-reftable-basics: use TEST_RUN > t-strvec: use TEST_RUN > t-strbuf: use TEST_RUN > > t/helper/test-example-tap.c | 33 +++ > t/t0080-unit-test-output.sh | 48 +---- > t/t0080/expect | 76 +++++++ > t/unit-tests/t-ctype.c | 4 +- > t/unit-tests/t-reftable-basics.c | 228 +++++++++----------- > t/unit-tests/t-strbuf.c | 79 +++---- > t/unit-tests/t-strvec.c | 356 ++++++++++++++----------------- > t/unit-tests/test-lib.c | 42 +++- > t/unit-tests/test-lib.h | 8 + > 9 files changed, 462 insertions(+), 412 deletions(-) > create mode 100644 t/t0080/expect > > -- > 2.45.2 One small nitpick on patch #3 and a question on #6, but basically this series looks good to me. I'll be away from email for the rest of the week, so I'll go ahead and sign off: Reviewed-by: Josh Steadmon <steadmon@xxxxxxxxxx>
